move desi_archive_tilenight contents into callable functions #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
bin/desi_archive_tilenightcontents into callable functions inscripts/archive_tilenight.pywithout changing the functionality of the script which is now a lightweight wrapper. This is an organizational step towards implementing the new missing petal archive option in #2080 , but I'm doing it as a separate PR so that the "real" implementation for #2080 has callable functions for testing while also being able to focus on what actually changed and not get lost in the reorganization of moving code out of a script and into functions.I intend to self-merge this, and then have a real review for the followup PR branched off of this.