New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add desi_link_calibnight script #2165
Conversation
Tests failed while installing astropy 5.0 (mis-match of checksums). Will retry in morning in case it is transient download and/or packaging glitch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the useful script that does exactly what we need, and kudos for the unit tests. This is very well covered. I have made some comments throughout. Some of these I have already discussed with you, while others are new. None of these are critical blocking factors, but there are choices that I'd like more insights on, and a few comments that you can choose to consider or ignore.
@akremin thanks for the review comments. I think I have addressed all of them; please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the responses and for the revisions. I originally had a question but have since understood the answer based on the code comments. I'm happy to approve this and merge it whenever you are ready.
New
desi_link_calibnight
script to simplify linking calibnight files from one night to another:By default this links badcolumns,biasnight,fiberflatnight,psfnight files, with a placeholder for ctecorr (to be updated after PR #2163), but the
--include
and--exclude
options can adjust that.It won't overwrite pre-existing files, unless those file happen to already be links to the same destination anyway.
Includes a full suite of unit tests. @akremin please review. Does this match what you need for pipeline calibnight linking?