New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctecorr flexibility #2194
ctecorr flexibility #2194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. I have added some comments inline where I think one piece should be moved, and then I provide some additional functions that might be useful. I also address how to incorporate BADAMPS into this.
@akremin I believe I have updated the camword logic to cover the cases you raised, including BADAMPS via erow_to_goodcamword. Please re-doublecheck my logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my requests were addressed in the latest commits. The implementation at line 604 in get_cte_images()
is better than my original suggestion because it quickly skips nights where the camera isn't used, while also capturing the case I was concerned about.
This PR makes the CTE correction code more flexible for cases when not correction is needed: