Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rrdesi --model option to desi_zproc #2226

Merged
merged 1 commit into from
Apr 26, 2024
Merged

add rrdesi --model option to desi_zproc #2226

merged 1 commit into from
Apr 26, 2024

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Apr 26, 2024

This PR adds the rrdesi --model ... option to the desi_zproc workflow so that redrock models are automatically output as part of the pipeline.

Example job script /global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/run/scripts/tiles/cumulative/11607/20240408/ztile-11607-thru20240408.slurm ran

srun -N 1 -n 64 -c 2 --gpu-bind=map_gpu:3,2,1,0 --cpu-bind=cores desi_zproc -t 11607 -g cumulative -n 20240408 -e 235004 -c a0123456789 --mpi --run-zmtl --max-gpuprocs 4

which ran rrdesi commands like

redrock.external.desi.rrdesi([
'-i', '/global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/tiles/cumulative/11607/20240408/coadd-0-11607-thru20240408.fits',
'-o', '/global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/tiles/cumulative/11607/20240408/redrock-0-11607-thru20240408.fits',
'-d', '/global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/tiles/cumulative/11607/20240408/rrdetails-0-11607-thru20240408.h5',
'--model', '/global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/tiles/cumulative/11607/20240408/rrmodel-0-11607-thru20240408.fits',
'--gpu', '--max-gpuprocs', '4'])

with output in /global/cfs/cdirs/desi/users/sjbailey/spectro/redux/rrmodel/tiles/cumulative/11607/20240408 including rrmodel*.fits files.

This is a followup to desihub/redrock#283 which added the rrdesi --model option.

@sbailey sbailey requested a review from akremin April 26, 2024 18:03
Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the changes are minimal and does what we want. When checking the log I did identify a minor redrock issue (desihub/redrock#301) but that is unrelated to this PR. I will approve and merge this.

@akremin akremin merged commit 4f8da22 into main Apr 26, 2024
26 checks passed
@akremin akremin deleted the rrmodel branch April 26, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants