Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only count bad readnoise on amps not already flagged as bad #2234

Merged
merged 1 commit into from
May 3, 2024

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented May 3, 2024

This PR fixes another badamp related conceptual bug: PSF fitting rejects CCDs with >12.5% of the pixels flagged as having bad readnoise. But now that we have better handling of bad amps that are pre-flagged as bad, we don't care what the readnoise is on those amps.

And example is night 20231205 where b5A and b5C are flagged as bad due to high readnoise. desi_proc was discarding the b5 arcs (without actually counting it as a fatal error) and then the psfnight was failing due to missing individual exposure psfs.

With this PR

  • bad readnoise is only counted if it is on pixels not already flagged as part of a known bad amp
  • if it passes threshold, this is treated as an error so that the job will exit with an error. i.e. we want to catch these cases and flag as bad in the exposure tables so that we don't trip on it next time.

I've tested this on the j1 production with this branch. I intended to self merge so that I can update and we can proceed with this Jura testing production.

@sbailey sbailey merged commit 8785ea9 into main May 3, 2024
26 checks passed
@sbailey sbailey deleted the psf2badamp branch May 3, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant