Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desispec.module #2245

Merged
merged 2 commits into from
May 15, 2024
Merged

Update desispec.module #2245

merged 2 commits into from
May 15, 2024

Conversation

Waelthus
Copy link
Contributor

@Waelthus Waelthus commented May 13, 2024

This patch updates the DESI_SPECTRO_DARK directory to a new one for upcoming observations. Currently, the new directory only contains symlinks to previous files, but new calibs for post-Y3 observations will go to the new directory only.

@Waelthus Waelthus marked this pull request as draft May 13, 2024 11:28
@Waelthus Waelthus marked this pull request as ready for review May 13, 2024 13:45
@Waelthus
Copy link
Contributor Author

added a symlink pointing to the most up-to-date directory, using that by default

@sbailey
Copy link
Contributor

sbailey commented May 15, 2024

Good idea to have a "latest" link so that we can update darks for desispec/main without having to re-install the desispec/main module file.

The jura production environment specifically enforces v2209 so it is safe to update this here. I will merge and update the desispec/main environment at NERSC.

@sbailey sbailey merged commit 87e2a22 into main May 15, 2024
26 checks passed
@sbailey sbailey deleted the update_desi_spectro_dark_dir branch May 15, 2024 22:48
@sbailey
Copy link
Contributor

sbailey commented May 15, 2024

Having just merged this, I'm no longer sure this is what we want to do, because this will also impact future tags, not just main. I don't think it is viable to assume that whenever we make a desispec tag will will remember to temporarily change this back to a tagged version. Rather than immediately undo this, I'm going to continue the conversation on desihub/desimodules#49 to see if we can converge on what the best practices should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants