Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline QA for SkySub Residuals #425

Merged
merged 19 commits into from Aug 14, 2017
Merged

Offline QA for SkySub Residuals #425

merged 19 commits into from Aug 14, 2017

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Aug 14, 2017

A series of changes to implement new QA (figures)
for skysub residuals.

  • Add frame_meta to parameters (for slurping the Frame headers)
  • Add get_reduced_frames() method to io.meta
  • Modifies QA_Prod meta file output to be JSON
  • Add load_meta() method to QA_Exposure
  • Add time_series ploting to desi_qa_prod
  • Add several new plots for skysub residuals
  • Adds method to generate QA Table for Prod
  • Refactor of skysubresid script

Here are a couple of example PNGs:

  1. Exposure (not the best)
    qa_skyresid_wave_expid_95b

  2. Production level

skyresid_prod_dual_r

  1. Gaussianity

skyresid_prod_gauss_z

@sbailey
Copy link
Contributor

sbailey commented Aug 14, 2017

Looks good. Highlighting one change where we should coordinate with online QA: this switches from YAML to JSON, presumably for performance when slurping in a full production worth of QA files. We can be temporarily out of sync while trying different format ideas, but eventually we should converge on the same basic format and structure for both online and offline QA.

@sbailey sbailey merged commit 764a428 into master Aug 14, 2017
@sbailey sbailey deleted the skyresid branch August 14, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants