Redrock pipeline integration #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the redrock worker class to match upstream interface
- Unify the slurm script generation between all NERSC machines.
- Compute the redrock batch times based on empirically
determined run times.
|
One note: these changes still are not very "smart" about changing runtimes for the different machines for each pipeline step. That is something that will be added soon. |
|
Hmm, not sure why the sphinx build is failing now, will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the redrock redshift fitting tool into the pipeline:
Update the redrock worker class to match upstream interface
Unify the slurm script generation between all NERSC machines.
Compute the redrock batch times based on empirically
determined run times.
Note that these changes are designed to work with the current MPI branch of redrock (which will eventually migrate into master). We can pre-emptively make these changes to the pipeline since the current redshift fitting is essentially unusable, so there is nothing to lose.