Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for review while I do the final cleanup (e.g. adding unit tests).
This PR is a complete rewrite of
desi_group_spectra
for several reasons:Known issues I want to fix before merging:
--nights
option became--night
(easy to fix)Known issues that may wait for a further update.
every frame, when the prior data did have that spectrograph channel.
In the name of optimization, this bypasses the standard
Frame
andSpectra
objects anddeispec.io.read/write
routines. TheFrameLite
andSpectraLite
objects here might be useful for other purposes (like QA) but are currently isolated intopixgroup.py
and are not intended to be generally useful objects with the full features ofFrame
andSpectra
. They are optimized for fast I/O and regrouping, but need unit tests to help ensure that they remain consistent with the standard more full-featured objects.