Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non uniform sky #506

Merged
merged 9 commits into from Feb 16, 2018
Merged

Non uniform sky #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d60ee64
non-uniform sky fit (polynomial of fiber focal plane x,y )
julienguy Feb 6, 2018
4c947e0
one comment
julienguy Feb 6, 2018
7ad3c2e
bring back add variance option in tests
julienguy Feb 9, 2018
4480a16
separate routines compute_uniform_sky compute_non_uniform_sky
julienguy Feb 9, 2018
0a2b6b4
in dev
julienguy Feb 12, 2018
60ee25d
running but biased
julienguy Feb 12, 2018
117e418
junk
julienguy Feb 12, 2018
78a244d
polynomial x sky flux version working
julienguy Feb 14, 2018
0bc7584
finalized fit of polynomial(x,y,wave) x sky spectrum
julienguy Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions py/desispec/scripts/sky.py
View file
Open in desktop
Expand Up @@ -32,7 +32,11 @@ def parse(options=None):
help = 'n sigma rejection for cosmics in 1D (default, no rejection)')
parser.add_argument('--no-extra-variance', action='store_true',
help = 'do not increase sky model variance based on chi2 on sky lines')

parser.add_argument('--angular-variation-deg', type = int, default = 0, required = False,
help = 'Focal plane variation degree')
parser.add_argument('--chromatic-variation-deg', type = int, default = 0, required = False,
help = 'wavelength degree for chromatic x angular variation. If -1, use independent focal plane polynomial corrections for each wavelength (i.e. many more parameters)')

args = None
if options is None:
args = parser.parse_args()
Expand Down Expand Up @@ -61,7 +65,7 @@ def main(args) :
apply_fiberflat(frame, fiberflat)

# compute sky model
skymodel = compute_sky(frame,add_variance=(not args.no_extra_variance))
skymodel = compute_sky(frame,add_variance=(not args.no_extra_variance),angular_variation_deg=args.angular_variation_deg,chromatic_variation_deg=args.chromatic_variation_deg)

# QA
if (args.qafile is not None) or (args.qafig is not None):
Expand Down