Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extract timing hook #509

Merged
merged 1 commit into from Feb 16, 2018
Merged

Add extract timing hook #509

merged 1 commit into from Feb 16, 2018

Conversation

rcthomas
Copy link
Contributor

  • Insert an optional timing=None argument. If this argument is a
    dict then it will be updated with timing information while the
    function is running.
  • Mark points in time for various phases including read_input,
    preparation, total_extraction_time, total_output_time,
    and merge and compute elapsed time from differences.
  • Marks and some timing computations are done whether or not any
    timing argument is passed, but it is only set if a dict is
    passed. Any other type of argument, the timing data is lost.

In the long run a more uniform strategy for collecting timing data
should be considered and these changes supplanted by that, but this
is good for present purposes of understanding where the code is
spending its time at various concurrencies.

* Insert an optional `timing=None` argument.  If this argument is a
  `dict` then it will be updated with timing information while the
  function is running.
* Mark points in time for various phases including `read_input`,
  `preparation`, `total_extraction_time`, `total_output_time`,
  and `merge` and compute elapsed time from differences.
* Marks and some timing computations are done whether or not any
  `timing` argument is passed, but it is only set if a `dict` is
  passed.  Any other type of argument, the timing data is lost.

In the long run a more uniform strategy for collecting timing data
should be considered and these changes supplanted by that, but this
is good for present purposes of understanding where the code is
spending its time at various concurrencies.
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks.

@sbailey sbailey merged commit f26273b into master Feb 16, 2018
@sbailey sbailey deleted the add-extract-timing-hook branch February 16, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants