Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits on metric's names #512

Merged
merged 2 commits into from Feb 22, 2018
Merged

Minor edits on metric's names #512

merged 2 commits into from Feb 22, 2018

Conversation

Srheft
Copy link
Contributor

@Srheft Srheft commented Feb 22, 2018

STAT-> STATUS, RsidRMS -> RESID are uniformly changed in both qa and quicklook directories. Changes from individual target names to a general target name (TGT) are done in ql_snr branch.

@sbailey
Copy link
Contributor

sbailey commented Feb 22, 2018

Looks good to me; I'll let someone from the QL team do the merge when ready.

@rkehoe
Copy link
Contributor

rkehoe commented Feb 22, 2018

Thanks @Srheft ! This will help. The branch is passing travis tests, so I will merge in a minute.

@rkehoe rkehoe merged commit 9b7b850 into master Feb 22, 2018
@weaverba137
Copy link
Member

Is there any reason not to delete this branch?

@Srheft Srheft deleted the minorEdits branch March 30, 2018 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants