Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize spectro file names/locations #545

Merged
merged 10 commits into from Mar 21, 2018
Merged

standardize spectro file names/locations #545

merged 10 commits into from Mar 21, 2018

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Mar 20, 2018

Opening this PR to get it into consideration for the 18.3 software release, even though it needs a bit more vetting / work before merging. This PR does some cleanup of spectro pipeline file names and locations for better consistency:

  • exposures/{night}/{expid}/pix*.fits -> preproc/{night}/{expid}/preproc*.fits
    • Reason: separate large pix files from other per-exposure files for easier backup and deletion
    • clearer name than "pix"
  • spectra-{nside}/{group}/{pix}/rrdetails_redshift_{nside}_{pix}.h5 ->
    spectra-{nside}/{group}/{pix}/redrock-{nside}-{pix}.h5
    • Reason: dash instead of underscore delimiter like others; shorter name
    • Note: data challenge prods so far have bypassed the pipeline anyway and have used "rr-{nside}-{pix}.h5".
    • TODO: the only place where I found the "rrdetails_redshift" name mentioned was in py/desispec/pipeline/attic/workers.py which doesn't smell like the place that it actually would be. Did I really fix this or not?
    • TODO (longer term): reformat hdf5 -> fits
  • calib2d -> calibnight
    • Reason: rescoped to be per-night calibs; includes fiberflats which aren't 2d
  • calib2d/psf/{night}/psfnight-{camera}.fits -> calibnight/{night}/psfnight-{camera}-{night}.fits
    • Reason: make filenames unique without relying upon directory structure too
  • calib2d/{night}/fiberflat-{camera}-{expid}.fits ->
    exposures/{night}/{expid}/fiberflat-{camera}-{expid}.fits
    • Reason: move per-exposure quantities back into per-exposure directories
  • calib2d/{night}/fiberflatnight-{camera}.fits ->
    calibnight/{night}/fiberflatnight-{camera}-{night}.fits
    • Reason: like psfnight, make filenames unique without relying upon directory structure too
  • calib2d/psf/{night}/psfboot-{camera}.fits ->
    exposures/{night}/{expid}/psfboot-{camera}-{expid}.fits
    • Reason: like PSF, grouping per-exposure outputs together
    • TODO: check usage of psfboot; it is no longer used by offline pipeline
  • TODO (later): QA usage of calib2d
  • TODO (later): io.findfile has lots of quicklook files mixed in with other directories instead of isolated into a quicklook area. Review that.

@sbailey sbailey requested a review from julienguy March 21, 2018 00:08
@sbailey
Copy link
Contributor Author

sbailey commented Mar 21, 2018

@julienguy please review and test; I've likely broken something for the pipeline...

Copy link
Contributor

@julienguy julienguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sims after a few bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants