Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues #580 and #582 . The new format for the metrics block on those QAs are
Count Pix: {'LITFRAC_AMP': [0.35, 0.37, 0.33, 0.35],
'LITFRAC_STATUS': 'NORMAL',
'NPIX_AMP': [1468029, 1555863, 1410426, 1488293]}
Count Bins: {'GOOD_FIBER': [1, 1, 1....,1, 1], 'NGOODFIB': 500,
'NGOODFIB_STATUS': 'NORMAL'}
This also updates the respective tests and static plots to address new (and single) thresholds and relevant keys.
@rkehoe @Srheft Please review when you get a chance. Let me know if this meets the requirements of those issues.