Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 1&2 of 7 #607

Merged
merged 9 commits into from May 4, 2018
Merged

Ticket 1&2 of 7 #607

merged 9 commits into from May 4, 2018

Conversation

Srheft
Copy link
Contributor

@Srheft Srheft commented May 2, 2018

@rstaten: left at your capable hands. This should hopefully address tickets #578 and #579.
Depending on the timing, we may add a thing or two (e.g., plot ideas, etc). Please comment/apply changes or ask for change wherever you see fit. Thank you.

@rstaten
Copy link
Contributor

rstaten commented May 3, 2018

@Srheft I made a few minor updates, but other than that this branch looks fine. Tickets #578 and #579 are addressed appropriately.

@rkehoe
Copy link
Contributor

rkehoe commented May 4, 2018

This branch is in good shape, and brings QL to complete 4 of the outstanding 7 tickets targeted for mock observing. We still appear to have 'RMS' named drill down metrics, but we can omit those in the next branch. I will take a look once tests are finished.

@Srheft
Copy link
Contributor Author

Srheft commented May 4, 2018

Let's add your last comment here too ():

The only RMS that I catch are:
RMS --> NOISE

  • RMS_AMP --> NOISE_AMP
  • PEAKCOUNT_RMS ---> PEAKCOUNT_NOISE
  • RESIDRMS ---> RESIDNOISE
  • MAX_RMS --> MAX_NOISE

No reason to change GET_RMS that is the PA name
No reason to change plot_RMS that is a function name

I tested the branch and it ran fine.

@rkehoe rkehoe merged commit 70aca9b into master May 4, 2018
@rkehoe rkehoe deleted the ql_HDUsnMore branch May 4, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants