Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic ray finder is faster uses less memory with numba #644

Merged
merged 1 commit into from Jun 26, 2018

Conversation

julienguy
Copy link
Contributor

Solves issue #612 . Reduced memory usage by a factor 4 using numba in the cosmic ray finder.

@sbailey
Copy link
Contributor

sbailey commented Jun 26, 2018

Tested on an r5 image on cori, I find 20.5 sec -> 12.5 sec, and 2.2G -> 1.2G. The pixels, ivar, and readnoise are identical, while a tiny fraction of the masked pixels changed their mask value. Most but not all of those were edge pixels; there were 9 interior pixels whose mask value changed. That's good enough for me, but holler if you want to check those for completeness.

@sbailey sbailey merged commit f32955b into master Jun 26, 2018
@sbailey sbailey deleted the lighter-cosmics branch June 26, 2018 20:29
@sbailey
Copy link
Contributor

sbailey commented Jun 26, 2018

For the record: Julien pointed out that the flat lamp exposures have higher S/N and the original algorithm used more memory in that case, so his 4x savings in memory isn't an exaggeration: it is indeed a 4x win for flats, which is huge because that will enable us to run all 30 cameras simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants