Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New QL calibration QAs #677

Merged
merged 8 commits into from Aug 18, 2018
Merged

New QL calibration QAs #677

merged 8 commits into from Aug 18, 2018

Conversation

rstaten
Copy link
Contributor

@rstaten rstaten commented Aug 16, 2018

This PR includes two new QuickLook QA algorithms developed by @eguzman that examine the final outputs from processing calibration exposures. Specifically, they:

  • Add a QA for arc processing that checks 'w' coefficients after resolution fit. These metrics are meant as a 'quick' assessment of whether calibration exposures provide final calibration results - in this case the wavelength resolutions.
  • Add a dummy QA for flat processing to validate continuum lamp exposures (to be updated with metrics in a future branch).
  • Take monthly psf files as input for resolution fit instead of deprecated bootcalib files.
  • Note: Further optimization of the included metrics will benefit from simulations with real world effects and commissioning data.

@Srheft, @rkehoe Please review these edits.

@rkehoe
Copy link
Contributor

rkehoe commented Aug 17, 2018

This is valuable to complete the last QAs for calibration processing. The update looks good, but I don't favor the use of an extra 'Data' dictionary out of the run method into the plotting. The coefficients should just be taken by the plotting from the psf object input.

However, that is under-the-hood and not important at the moment. I'd rather merge this now and then can clean that up later, maybe when fleshing out the fiber flat metric.

@Srheft Thanks ahead for following up with your test to a merge.

@Srheft
Copy link
Contributor

Srheft commented Aug 18, 2018

@rstaten, @eguzman thanks for your work on this. As discussed internally:

  • The currently executed idea for this QA has been suggested in ticket Adding a new QA for check resolution  #657 to which no comments were received thus we moved on with place holders.

  • This PR adds two QAs called Check_FiberFlat with scalar metric called FFLMEAN and Check_Resolution with three metrics: Medians, RMS, NBADCOEFFS (see qa_quicklook.py )

  • The feasibility of the suggested quantities to be reported in these QAs is not obvious to me/some. The metrics in these QAs will be completed and/or altered upon access to faulty exposures where the traces of the bad fibers exhibit measurable characteristic behavior; one of which could be an out-of-norm set of best-fit Legendre polynomial or a flat-out failure to find a solution for the fit, etc. The metric to check the quality of fiber flat also needs a full revision.

  • Ticket New PSF format fails QL #681 addresses the recently inflicted failure in arc processing.

@Srheft Srheft merged commit d56f96a into master Aug 18, 2018
@sbailey sbailey deleted the new_qlQAs branch October 4, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants