Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xytraceset in quicklook #682

Merged
merged 10 commits into from Aug 22, 2018
Merged

xytraceset in quicklook #682

merged 10 commits into from Aug 22, 2018

Conversation

julienguy
Copy link
Contributor

Replace all instances of quicklook.qlpsf.PSF by in quicklook , modify read_xytraceset and add write_xytraceset.
This PR fixes the issue #681 .

@julienguy
Copy link
Contributor Author

I realize my description of the pull request was not intelligible, sorry for that. Let me try again:

  • I replaced everywhere in quicklook the use of the class qlpsf.PSF by the class desispec.xytraceset which is used in the offline pipeline. xytraceset is a container for the trace coordinates and the PSF sigma values.
  • I added write_xytraceset in desispec.io.xytraceset
  • This is to make sure we use only one set of IO routines for spectral traces in desispec, in order to avoid inconsistencies as reported in issue New PSF format fails QL #681.
  • This turned out to touch a lot of files in quicklook.

@rstaten
Copy link
Contributor

rstaten commented Aug 22, 2018

I have tested this branch on arcs and science and no longer receive the errors we were previously seeing. Thanks for this fix.

@sbailey
Copy link
Contributor

sbailey commented Aug 22, 2018

Thanks for testing @rstaten. Merging now.

@sbailey sbailey merged commit 42982e4 into master Aug 22, 2018
@sbailey sbailey deleted the xytraceset_in_quicklook branch August 22, 2018 16:49
@sbailey sbailey mentioned this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants