Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desi pipe sync spectra #692

Merged
merged 2 commits into from Sep 14, 2018
Merged

Desi pipe sync spectra #692

merged 2 commits into from Sep 14, 2018

Conversation

julienguy
Copy link
Contributor

Adding option desi_pipe sync --force-spec-done to change the state of spectra and redshift tasks if spectra files exist even in case there is no cframe files on disk. This is useful to redo a redshift run starting from a pre-existing prod.

@tskisner
Copy link
Member

Just trying to understand the motivation a little more... So some cframes exist, the spectra file is generated, then the cframes are deleted. Normally this would mark the spectra file as not done, since one of its inputs is missing.

In your case, what happened to the cframes? Or are you starting from an empty production and manually copying in the spectra files from elsewhere?

If we are supporting the general case of "starting in the middle" of a production (for example, copying just the cframe files into place), then maybe we should have a general option to desi_pipe sync which says something like, "Only look at the files and not their dependencies". So if any file exists it is marked as done, otherwise as waiting, with no dependency checking.

Thoughts?

@julienguy
Copy link
Contributor Author

  • "Or are you starting from an empty production and manually copying in the spectra files from elsewhere?"
    Yes. This is to test/debug redrock.
  • It's a good point that we may want to have this feature more generic.

@tskisner
Copy link
Member

tskisner commented Aug 29, 2018 via email

@sbailey sbailey merged commit 34581dc into master Sep 14, 2018
@sbailey sbailey deleted the desi-pipe-sync-spectra branch September 14, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants