QL config update and fibermap conform - #699 changes #702
Conversation
|
@felipelm I am unclear on why you are asking anybody but @Srheft to review this PR. I have completed my review of 699. As indicated in the GitHub thread, @Srheft has done by far the bulk of the work for PR #699, and any further tweaks she can do belong in that PR with that thread of comments. @Srheft is tasked with finishing up getting this code into master. Please point your comments directly at her. @Srheft I think the most expedient thing is to delete this PR and proceed either from 699 or a new PR with further updates. I defer to your judgment on this pending your requested comments from stephen. |
|
@rkehoe I am keeping the original reviewers from the other pull request as it was mistakenly merged. No need to review this one if you are happy with 699 as both have the same changes. We were afraid to break something without reverting the changes quickly. Sorry for the trouble. |
This PR restores the changes removed with #701 and has all the changes from #699.
The commit history and comments can be found on the other pull request.