fixes desi_zcatalog --fibermap for new format fibermap #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes desihub/desisim#448, where
desi_zcatalog --fibermap
didn't work for the new format fibermap. This implementation works on zbest files with both old and new format fibermap tables, and adds columnsRA
,DEC
,FLUX_G
,FLUX_R
,FLUX_Z
in both cases, even though the old version used to writeMAG
instead.Unlike the discussion in desihub/desisim#448 this morning, I actually have tested it this time, using the 18.7 (old) and 18.11 (new) reference runs in /project/projectdirs//desi/datachallenge/reference_runs/ .
@TEtourneau please take a look if you'd like. Otherwise I'll merge tomorrow morning.