Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimize warnings for resolution fit #756

Merged
merged 1 commit into from Jan 24, 2019
Merged

minimize warnings for resolution fit #756

merged 1 commit into from Jan 24, 2019

Conversation

rstaten
Copy link
Contributor

@rstaten rstaten commented Jan 23, 2019

This PR minimizes the warnings generated by resolution fit. The algorithm runs fine, but if a line is not able to be fit, we do not need to log extra information.

@rkehoe Please check this and merge when possible.
@felipelm At your convenience, please include this update in your latest QLF version.

@rkehoe
Copy link
Contributor

rkehoe commented Jan 24, 2019

@rstaten. Thanks for getting this out there. This solution, of dropping the fiber when one of the lines does not fit, is expedient now. But it would be better to preserve the information per fiber of how many lines were fit, and keep fibers unless the percentage failing is less than some fraction. One does need quite a few lines to get a decent Legendre polynomial fit, but missing one line out of, say, 16, is not going to fundamentally cripple that usually.

Needs a study! So I’ll merge this and hopefully somebody gets to tune this up!

@rkehoe rkehoe merged commit 5cd4452 into master Jan 24, 2019
@rkehoe rkehoe deleted the ql_arcs branch June 19, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants