Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KPNO transfer script #758

Merged
merged 4 commits into from Feb 27, 2019
Merged

Update KPNO transfer script #758

merged 4 commits into from Feb 27, 2019

Conversation

weaverba137
Copy link
Member

This PR updates the non-essential KPNO->NERSC transfer script. This now supports the spectrograph functional verification tests. In addition, this script is currently triggered directly from cron (once a day at noon MST) rather than running as a daemon, although that capability still exists.

@weaverba137 weaverba137 self-assigned this Feb 26, 2019
@sbailey
Copy link
Contributor

sbailey commented Feb 26, 2019

It looks like this update is replacing the syncing of KPNO:/data/dts/exposures/raw -> NERSC:${DESI_SPECTRO_DATA} with a sync of KPNO:/exposures/desi/sps -> ${DESI_ROOT}/engineering/spectrograph/sps instead. Is the intension that at some point in the future we would switch back?

There might be a time period when we are taking multi-spectrograph data into KPNO:/data/dts/exposures/raw while still finishing functional verification of the final spectrographs in KPNO:/exposures/desi/sps. i.e. it seems like for now we need to support syncing multiple locations on multiple timescales rather than replacing one sync with another.

Caveat: I haven't understood why the spectrograph FV tests aren't being written to the final standard KPNO:/data/dts/exposures/raw location, or whether the reasons are technical or philosophical.

@weaverba137
Copy link
Member Author

@sbailey, there is no replacement going on. This script is for the non-essential transfers. The desi_dts.sh script is unchanged, and in fact that script has been continuously active for several weeks.

This really seems to be a point of confusion. Did everyone except me forget that we have two different data transfer scripts?

@sbailey
Copy link
Contributor

sbailey commented Feb 26, 2019

OK, that sounds fine. I was confused by desi_kpno_transfer.sh having /data/dts/exposures/raw in it and thinking that this was the primary raw data transfer script and that you hadn't added the second script yet (instead of this being the second script, with desi_dts.sh being the other one).

It can be a separate update, but perhaps we need different names for these. From their names, desi_dts.sh and desi_kpno_transfer.sh sound like they do the same thing. I don't have a good alternate suggestion yet though...

@weaverba137
Copy link
Member Author

@sbailey, thanx. I'm going to let the script run for another day or so before merging. I'll see if I can think of another name.

@weaverba137
Copy link
Member Author

Punting the script renaming issue to #761. Will merge as soon as tests pass.

@weaverba137 weaverba137 merged commit 53ccd6f into master Feb 27, 2019
@weaverba137 weaverba137 deleted the update-kpno-transfers branch February 27, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants