Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leftover files when rerunning unit tests #776

Merged
merged 2 commits into from May 30, 2019
Merged

Conversation

rstaten
Copy link
Contributor

@rstaten rstaten commented Apr 26, 2019

This PR addresses #774, removing temporary files generated by QuickLook unit tests that are not removed if test_ql_qa.py is killed while running.

@rkehoe, @sbailey Please review and/or provide any necessary additional comments.

@rkehoe
Copy link
Contributor

rkehoe commented Apr 26, 2019

Thanks @rstaten. Looks fine as a first pass. As we discussed, a more robust solution may be to develop a signal handler for this, but that should be contingent on QL development questions still TBD elsewhere. This at least removes the item that was thwarting others. So if @sbailey is okay with it as a first pass, I’m okay with it.

@sbailey sbailey merged commit 194a676 into master May 30, 2019
@sbailey sbailey deleted the ql_unittest_fix branch May 30, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants