Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darktrail #798

Merged
merged 3 commits into from Jul 19, 2019
Merged

Darktrail #798

merged 3 commits into from Jul 19, 2019

Conversation

julienguy
Copy link
Contributor

Code to fit and correct dark trails.

  • desi_compute_dark_trail [-h] -i INFILE [-p PSF] [--plot] -a AMPLIFIER
    • Computes a cross-dispersion profile from a continuum and the trace coordinates saved in a PSF
    • Fits a dark trail assuming some symmetry in the profile.
  • py/desispec/darktrail.py contains the function correct_dark_trail that is called by the preprocessing
    if the keywords DARKTRAILAMPX DARKTRAILWIDTHX with X in ABCD are found in the calibration yaml file like https://desi.lbl.gov/trac/browser/calib/desi_spectro_calib/trunk/spec/sp5/r5.yaml

This is a poor man software fix to the readout issue described in #796 .

@sbailey
Copy link
Contributor

sbailey commented Jul 19, 2019

Looks good, thanks. Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants