help numba know the types

[sbailey]

This PR enables numba to understand the types used within desispec.cosmics._reject_cosmic_rays_ala_sdss_single_numba and dilate_numba. I don't understand why it couldn't handle the previous more obvious dtype=int and dtype=bool, but that resulted in slews of numba deprecation warnings about falling back to object mode but finding lifted loops blah blah blah.

A secondary benefit of this is that it allows @numba.jit(nopython=True) which makes cosmic ray rejection ~2x faster resulting in ~20% faster preprocessing.

[lastephey]

That's great! The numba developers at scipy recommended always setting nopython=True for this reason.

…

On Thu, Aug 1, 2019, 17:42 Stephen Bailey ***@***.***> wrote: This PR enables numba to understand the types used within desispec.cosmics._reject_cosmic_rays_ala_sdss_single_numba and dilate_numba. I don't understand why it couldn't handle the previous more obvious dtype=int and dtype=bool, but that resulted in slews of numba deprecation warnings about falling back to object mode but finding lifted loops blah blah blah. A secondary benefit of this is that it allows @numba.jit(nopython=True) which makes cosmic ray rejection ~2x faster resulting in ~20% faster preprocessing. ------------------------------ You can view, comment on, or merge this pull request online at: #802 Commit Summary - help numba know the types File Changes - *M* py/desispec/cosmics.py <https://github.com/desihub/desispec/pull/802/files#diff-0> (10) Patch Links: - https://github.com/desihub/desispec/pull/802.patch - https://github.com/desihub/desispec/pull/802.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#802?email_source=notifications&email_token=ABPRR5GDHTSN5B2HLTSVL7TQCN7F3A5CNFSM4IIZFOUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HC6LTWQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPRR5BVR7653JJAVX6GXULQCN7F3ANCNFSM4IIZFOUA> .