Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several updates #850

Merged
merged 21 commits into from Nov 15, 2019
Merged

Several updates #850

merged 21 commits into from Nov 15, 2019

Conversation

julienguy
Copy link
Contributor

  • desi_proc: use psfnight or fiberflat night if exist
  • add utility scripts for booting psf with dead fibers and bright CCD columns
  • new options in bootcalib
  • new options in desi_average_fiberflat
  • new options in desi_compute_psf

@julienguy
check for psfnight, adapt wavelength range of B
a26508a
@julienguy
option to disable psf merge, add comments with input files in headers…
b0cbe2d 
… of averaged psf
@julienguy
use image.mask! , and add option to choose threshold for trace detection
50cffdb
@julienguy
add option to choose threshold for trace detection, add option to NOT…
0d981e8 
… refit outlier fiber traces
@julienguy
add option to filter input images with program keyword
cabaa1e
@julienguy
use fiberflatnight instead of one in DESI_SPECTRO_CALIB if exists
47b9de7
@julienguy
add 2 utility scripts for booting PSFs
bacdcd0
@julienguy
auto-compute psfnight if >=5 PSFs measured for this night
9621a00
@julienguy
calibfinder.findcalibfile returns None instead of raising exception i…
8654fbc 
…f keyword not found
@julienguy
deal with broken fibers
ee92cf0
@julienguy
use findfile('fiberflatnight',...) for outputs
ee97fac
@julienguy
auto compute night psf, night fiberflat, and use them for sky and sci…
6c9d0d4 
…ence data processing
@julienguy
survive a missing FLAVOR keyword
0dc4f92
@julienguy
survive a missing FLAVOR keyword (for WLINLIGHT data analysis)
f2dd8e9
@julienguy
add more cosmic ray filtering
c1a4537
@julienguy
adapted wavelength range
68f936a
@julienguy
Copy link
Contributor Author

Ready for review/merge. Added new wavelength grid adapted to the sensitivity range of all 24 cameras.
Used to run night 20191108 including automated averaging of PSF and fiberflat (with auto-calibration of lamp intensities). One obvious area of future improvements: cosmic rays, but that's for another day.

@sbailey
Copy link
Contributor

sbailey commented Nov 15, 2019

Changes look good in principle but please fix up tests in test_fiberflat and test_binscripts.

@sbailey sbailey merged commit cf4997a into master Nov 15, 2019
@sbailey sbailey deleted the psfnight branch November 15, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienguy @sbailey