Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration #865

Merged
merged 18 commits into from Feb 4, 2020
Merged

Calibration #865

merged 18 commits into from Feb 4, 2020

Conversation

julienguy
Copy link
Contributor

Improved robustness of sky subtraction and flux calibration to poorly constrained wavelength regions and dead fibers, selection of standard stars. Also mask out the region between 4300 and 4500A with the throughput dip in the fit of standard stars.

For illustration, throughput per spectrograph of one exposure on a dither sequence (exposure 44565 from 2020/01/27):

flux-calib-44565

@sbailey
Copy link
Contributor

sbailey commented Feb 4, 2020

It looks like new fluxcalibration quality cuts are causing the desi_compute_fluxcalibration tests to discard all stars and thus fake-fail. Let's try to find a fix for that, or otherwise disable the test before merging if we have to.

@sbailey sbailey merged commit df9c4e5 into master Feb 4, 2020
@sbailey sbailey deleted the fibermap-fluxcalib branch February 4, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants