Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluxcalib minisv #898

Merged
merged 5 commits into from Mar 3, 2020
Merged

Fluxcalib minisv #898

merged 5 commits into from Mar 3, 2020

Conversation

julienguy
Copy link
Contributor

Several minor changes to improve the flux calibration, the important ones being:

  • use only target bits STD_FAINT|STD_BRIGHT|SV0_STD_FAINT|SV0_STD_BRIGHT
  • do not use any more option --highest-throughput in call to desi_compute_flux_calibration in desi_proc
  • use 3 sigma outlier rejection of stars based on their median throughput by default in compute_flux_calibration

@sbailey
Copy link
Contributor

sbailey commented Mar 3, 2020

Looks good. This might "break" flux calibration for very early data with badly miscentered stars, but that was pretty broken anyway. Looks good for minisv2 which should be our focus.

@sbailey sbailey merged commit ff09bd8 into master Mar 3, 2020
@sbailey sbailey deleted the fluxcalib-minisv branch March 3, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienguy @sbailey