Fix bugs.

bin/afternoon_plan

@@ -2,13 +2,15 @@
 
 import desisurvey.scripts.afternoon_plan
 import sys
+import traceback
 
 if __name__ == '__main__':
     try:
         args = desisurvey.scripts.afternoon_plan.parse()
         retval = desisurvey.scripts.afternoon_plan.main(args)
     except Exception as e:
         print(e)
+        print(traceback.format_exc())
         sys.exit(-1)
     if retval is not None and retval != 0:
         sys.exit(retval)

doc/changes.rst

@@ -13,6 +13,9 @@ desisurvey change log
 * Add option for disabling network access during afternoon planning.
 * Do not force BACKUP program during day if another program is
   explicitly requested.
+* More carefully log things associated with holding pen construction.
+* Check that permissions of holding pen are correct following construction.
+* Print out tiles for which offline information is missing during AP.
 
 .. _`#151`: https://github.com/desihub/desisurvey/pull/151
 

py/desisurvey/scripts/run_plan.py

@@ -10,6 +10,7 @@
 import desisurvey.utils
 import desisurvey.tiles
 import desisurvey.ephem
+import desisurvey.config
 from astropy.time import Time
 from astropy.coordinates import EarthLocation
 from astropy import units as u
@@ -225,17 +226,17 @@ def run_plan(night=None, nts_dir=None, verbose=False, survey=None,
     planplot(tilelist, nts.planner,
              title='%4d%02d%02d' % (night.year, night.month, night.day))
     if makebackuptiles:
-        import desisurvey.config
         backuplogdir = os.path.join(
-            os.path.dirname(desisurvey.config.Configuration.file_name),
+            os.path.dirname(desisurvey.config.Configuration().file_name),
             'backup-tile-logs')
-        os.mkdir(backuplogdir)
+        if not os.path.exists(backuplogdir):
+            os.mkdir(backuplogdir)
         make_tiles(tilelist, nts.planner, logdir=backuplogdir)
         check_permissions()
 
 
 def check_permissions():
-    from os import stat
+    import stat
     hpdir = os.environ.get('FA_HOLDING_PEN', None)
     log = desiutil.log.get_logger()
     bad = False