Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ERFA import error #136

Merged
merged 1 commit into from Apr 12, 2021
Merged

Fix ERFA import error #136

merged 1 commit into from Apr 12, 2021

Conversation

weaverba137
Copy link
Member

This PR fixes #134. @sbailey, could you please test in the candidate desiconda environment?

@weaverba137 weaverba137 self-assigned this Apr 12, 2021
@sbailey
Copy link
Contributor

sbailey commented Apr 12, 2021

Thanks. I confirm that:

  1. this works with astropy 4.0.1.post1 used in 20200801-1.4.0-spec (current default, i.e. it doesn't break backwards compatibility)
  2. this works with astropy 4.2 in draft desiconda release 20210326-1.5.0-spec (good)
  3. current master does not work with 20210326-1.5.0-spec (i.e. I'm testing what I think I'm testing in (2))

i.e. ok to merge.

That being said, unit tests are now failing under astropy 4.2 for a different reason for which I will open a different ticket to keep PR topics separate.

@sbailey sbailey merged commit 502d3b0 into master Apr 12, 2021
@sbailey sbailey deleted the pyerfa branch April 12, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

desisurvey broken with astropy 4.2
2 participants