Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support astropy 4.2; switch to github actions for testing #138

Merged
merged 7 commits into from
Apr 23, 2021

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Apr 23, 2021

This PR

  1. fixes reading horizons_2020_week1_moon.csv broken under astropy 4.2 #137 by fixing the parsing of horizons moon ephem under astropy 4.2
  2. fixes revive tests with GitHub actions #133 by switching from travis to github actions for CI testing

I suspect that (2) will take me a few more iterations to get the config right, so apologies in advance for the spam while I test the tests.

@sbailey
Copy link
Contributor Author

sbailey commented Apr 23, 2021

@weaverba137 could you setup a COVERALLS_REPO_TOKEN for desisurvey? I'm not sure if we ever had coveralls configured for desisurvey, and/or what the procedure is to do that. Thanks.

@weaverba137
Copy link
Member

Done!

@sbailey
Copy link
Contributor Author

sbailey commented Apr 23, 2021

Thanks @weaverba137 .

@dkirkby @schlafly I think this is a straightforward PR to replace travis tests with github actions, and to fix tests under astropy 4.2 . It does not change any core code (only tests). I'll leave this open for a bit if you have any comments or requests, but otherwise I plan to merge this by the end of today and make a new desisurvey tag.

@schlafly
Copy link
Contributor

Let me just thank you for fixing this. I don't see any issues. Feel free to merge.

@dkirkby
Copy link
Member

dkirkby commented Apr 23, 2021

Yes, thanks @weaverba137!

@sbailey sbailey merged commit 5179574 into master Apr 23, 2021
@sbailey sbailey deleted the astropy_testing branch April 23, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reading horizons_2020_week1_moon.csv broken under astropy 4.2 revive tests with GitHub actions
4 participants