-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to override config file and tiles file #62
Conversation
I did make the 0.9.0 tag at the appropriate time, but forgot to push it (now fixed). |
I see you edited |
Let's pull the docs at the head of |
py/desisurvey/rules.py
Outdated
slope = float(dec_order) | ||
epsilon = float(hi>lo) #- used to avoid 0.0 / 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be float(lo>=hi)
so epsilon is normally zero? In any case, epsilon=0 or 1 doesn't seem intuitive here. Perhaps simpler to just add a third if clause below?
if lo == hi:
dec_priority[group_sel] = 1.
elif slope > 0:
...
else:
...
|
postfacto comment: the new unit tests run fast when using a desimodel test data subset, but are too slow when running on desimodel svn trunk data with all tiles. I will fix that now. |
This PR adds several features useful for small scale functional testing:
--config-file
option for scripts enabling overriding the default configuration filetiles_file
parameter to specify the DESI tiles file to use (requires desimodel >=0.9.0; defaults to desi-tiles.fits as before)Other changes along the way:
A companion update to surveysim will add the
--config-file
option there and update the tutorial instructions.I suggest making tag 0.9.0 after this is merged (version file was already update but tag never made...)