-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depth first #66
Depth first #66
Conversation
I am still working on an issue with |
This is ready to merge now. |
Regarding the progress columns: these are the "covered", "available", and "planned" columns? They are integer days since start of survey (not dates or MJDs)? For the record could you define (again) the difference between "available" and "planned"? i.e. what's the recipe for knowing when to run fiber assignment on what tiles? Clarifying: whether a tile is "covered" or not depends upon the rules file, correct? Or is it just "all tiles from previous layers that cover this tile have now been observed" regardless of whether the rules file says you should wait for them or not? Code looks fine to merge, but I'd like to document how to use those progress columns. |
I now see that you defined when to run fiberassignment in issue #24:
|
Correct. In particular, this section of
I decided to treat this as config, rather than hardcoded, since we currently treat P3 differently from other DARK layers. Also, note that:
is subtly different from:
(but I think this only matters at the edges). |
This PR adds the following features:
rules-depth.yaml
)