do not assume that input tile file includes all of DARK, BRIGHT, and GRAY tiles #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't be surprised if something else breaks with only DARK tiles (which will be good to know), but this is already an improvement so go ahead and merge when convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this simple PR are to accommodate the SV Data Challenge.
surveyinitcurrently assumes that the tile file includes a mixture of DARK, BRIGHT, and GRAY tiles, and crashed when I gave it a minimal tile file with just DARK tiles, and so I added a simpleifstatement to check.The second change (to
surveymovie) was to use uppercase column names when grabbing data from theexposures.fitsfile (which perhaps was standardized elsewhere / previously?).