Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFS/NTS interface to desisurvey scheduler #99

Merged
merged 6 commits into from
Jul 16, 2019

Conversation

schlafly
Copy link
Contributor

Adds Next Tile Selector functionality to the desisurvey scheduler.

The key addition of this routine to desisurvey is the NTS.py module that connects to the DOS NFS.py module to give the online system access to the desisurvey scheduler.

A few minor changes were made outside NTS.py:

  • Planner and Scheduler save(...) methods were made atomic
  • scheduler.next_tile(...) now accepts an program argument. Tiles are selected from this program.
  • next_tile also takes a skylevel argument, which is presently ignored.
  • tiles.index(...) now accepts a default False return_mask argument. If True, instead of raising an exception if an invalid tile ID is sent, the function returns a mask, indicating which IDs were valid.

Copy link
Member

@dkirkby dkirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add your RA,DEC swap bug fix to this PR? (or make a new PR if you prefer)

py/desisurvey/NTS.py Outdated Show resolved Hide resolved
py/desisurvey/NTS.py Outdated Show resolved Hide resolved
py/desisurvey/NTS.py Outdated Show resolved Hide resolved
py/desisurvey/NTS.py Show resolved Hide resolved
@schlafly
Copy link
Contributor Author

These changes should resolve the ra/dec <-> dec/ra mixup and improved the NTS documentation.

@schlafly schlafly closed this Jul 15, 2019
@schlafly schlafly reopened this Jul 15, 2019
@dkirkby
Copy link
Member

dkirkby commented Jul 15, 2019

The changes look good, thanks! I am restarting the travis job that failed since it looks like a network glitch.

@dkirkby
Copy link
Member

dkirkby commented Jul 16, 2019

Tests passing now.

@dkirkby dkirkby merged commit dfd8759 into desihub:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants