You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@geordie666, a minor correction to the changes in respect of #410. Not urgent, can be fixed in the next round of updates.
The MWS-BROAD targets should also be limited to g-r > 0.7, like the MAIN-RED targets. We want BROAD to be the complement of the astrometric cuts that only apply to RED. We don't apply any of the astrometry cuts to BLUE in the first place, so we don't want all the blue targets that fail those cuts to be counted as BROAD as well as BLUE.
However, it looks like the code added in #418 doesn't include that colour cut for BROAD:
@geordie666, a minor correction to the changes in respect of #410. Not urgent, can be fixed in the next round of updates.
The MWS-BROAD targets should also be limited to g-r > 0.7, like the MAIN-RED targets. We want BROAD to be the complement of the astrometric cuts that only apply to RED. We don't apply any of the astrometry cuts to BLUE in the first place, so we don't want all the blue targets that fail those cuts to be counted as BROAD as well as BLUE.
However, it looks like the code added in #418 doesn't include that colour cut for BROAD:
desitarget/py/desitarget/cuts.py
Lines 686 to 693 in eb1c2d2
Rather than
broad = mws.copy()
I think this should havebroad = red.copy()
in the same place (i.e. before the astrometry cuts are applied tored
).This is what we wrote on the TS page, but sorry I didn't catch it in the PR.
The text was updated successfully, but these errors were encountered: