Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to target selection algorithms, mostly for SV #418

Merged
merged 26 commits into from Nov 10, 2018
Merged

Conversation

geordie666
Copy link
Contributor

Includes:

  • First full implementations of QSO, LRG, ELG, and STD target classes for SV.
  • Update and refactor of the MWS and BGS classes for the main survey.
  • Change the name of the main survey MWS_MAIN class to MWS_BROAD.
  • Augment the QA code to handle SV sub-classes such as the ELG_FDR_FAINT class.

@moustakas: It's always possible that changes to cuts.py will break the mocks. A few things to look out for:

  • This PR addresses MWS-MAIN target definition and priority need to be changed #410, which you requested to be left open.
  • The _prepare_optical_wise function now includes a dchisq return, which was needed for SV morphology checks (...dchisq, deltaChi2, brightstarinblob = _prepare_optical_wise(...).
  • I refactored the main survey LRG selection, in a way that I think will work naturally with the mocks, but which could break inputs and outputs.

@apcooper: It'd be great if you could take a look at the new MWS selection code and check that I've addressed #410.

Copy link
Contributor

@apcooper apcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem to be exactly what we asked for in #410, thanks.

Copy link
Member

@moustakas moustakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that these changes don't break select_mock_targets but I'll need to check the effect on (mock) target densities, etc., in a separate branch.

And @geordie666 thanks for the refactor in cuts which makes the code more modular and readable.

@geordie666 geordie666 merged commit eb1c2d2 into master Nov 10, 2018
@geordie666 geordie666 deleted the ADMcutsSV branch November 10, 2018 03:06
qmxp55 pushed a commit to qmxp55/desitarget that referenced this pull request Feb 12, 2020
Updates to target selection algorithms, mostly for SV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants