New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to target selection algorithms, mostly for SV #418
Conversation
…ng new and different bits
…in survey quasar color cuts.
… are different from the main survey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to be exactly what we asked for in #410, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that these changes don't break select_mock_targets
but I'll need to check the effect on (mock) target densities, etc., in a separate branch.
And @geordie666 thanks for the refactor in cuts
which makes the code more modular and readable.
Updates to target selection algorithms, mostly for SV
Includes:
QSO
,LRG
,ELG
, andSTD
target classes for SV.MWS
andBGS
classes for the main survey.MWS_MAIN
class toMWS_BROAD
.ELG_FDR_FAINT
class.@moustakas: It's always possible that changes to
cuts.py
will break the mocks. A few things to look out for:_prepare_optical_wise
function now includes adchisq
return, which was needed for SV morphology checks (...dchisq, deltaChi2, brightstarinblob = _prepare_optical_wise(...
).@apcooper: It'd be great if you could take a look at the new MWS selection code and check that I've addressed #410.