Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filenames for targets to make them more unique #633

Closed
geordie666 opened this issue Jul 29, 2020 · 2 comments
Closed

Update filenames for targets to make them more unique #633

geordie666 opened this issue Jul 29, 2020 · 2 comments

Comments

@geordie666
Copy link
Contributor

Currently, targets (and the associated directory structure) look like:

target/catalogs/dr8/0.39.0/targets/sv1/resolve/bright/sv1-targets-dr8-hp-21.fits

To make the filenames unique but free of extraneous information, make the following updates in io.find_target_files():

  • Remove the trailing hyphen between sv1 and targets in the filename (sv1targets instead of sv1-targets).
  • Remove the imaging release in the filename completely (targets- instead of targets-dr8).
    • Should probably also add a DR keyword to the header, to ensure that information is recorded somewhere in the file.
  • Main Survey filenames should (still) look like targets- without any trailing main.
  • Add the observing "layer" (bright/dark) to the filenames.
  • Add noresolve to the filenames where needed for the rare cases that we release targets that are not resolved across the "North"/"South" imaging.

Some example results should look like:

target/catalogs/dr8/0.41.0/targets/main/resolve/dark/targets-dark-hp-33.fits
target/catalogs/dr8/0.41.0/targets/main/resolve/bright/targets-bright-hp-33.fits
target/catalogs/dr8/0.41.0/targets/sv1/resolve/dark/sv1targets-dark-hp-33.fits
target/catalogs/dr8/0.41.0/targets/main/noresolve/bright/targets-dark-noresolve-hp-33.fits
@sbailey
Copy link
Contributor

sbailey commented Jul 29, 2020

Thanks. Expanding on this point more generally:

Should probably also add a DR keyword to the header, to ensure that information is recorded somewhere in the file

Indeed. As a general principle throughout all our code and files, any metadata that is encoded in the directory structure and filename should also be present in the header keywords. i.e. the directories and filenames are useful for finding the files and keeping ourselves organized, but the contents of the file should also be sufficient to re-derive the associated metadata to recreate the filepath and filename.

@geordie666
Copy link
Contributor Author

Addressed in #637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants