New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update QSO selection for SV, minor improvements to random catalog generation #449
Conversation
…tic/edison/dust/v0_1 environment variable if the dust directory is not passed
@CAClaveau and/or @Cyeche: Could you please check that this PR agrees with what you'd expect for your proposed updates to the QSO Random Forest selection in SV (the first commit of the PR)? If this does look correct, could you please update the SV wiki page: https://desi.lbl.gov/trac/wiki/TargetSelectionWG/SurveyValidation#QuasarsQSO22:MultivariateSelection to reflect your new selection? |
@CAClaveau: After our conversation over email, I've made your requested corrections to the SV QSO selection code. Can you please check to see if this now looks correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geordie666: OK, everything looks correct, thank you.
Update QSO selection for SV, minor improvements to random catalog generation
This PR:
DUST_DIR
environment variable when generating randoms if a map directory is not passed.