Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QSO selection for SV, minor improvements to random catalog generation #449

Merged
merged 8 commits into from Jan 17, 2019

Conversation

geordie666
Copy link
Contributor

This PR:

  • updates the QSO random forest for SV to facilitate different selections in the north and south.
  • adds seeds to the random catalog generation for better reproducibility.
  • defaults to using the DUST_DIR environment variable when generating randoms if a map directory is not passed.

@geordie666
Copy link
Contributor Author

@CAClaveau and/or @Cyeche: Could you please check that this PR agrees with what you'd expect for your proposed updates to the QSO Random Forest selection in SV (the first commit of the PR)?

If this does look correct, could you please update the SV wiki page:

https://desi.lbl.gov/trac/wiki/TargetSelectionWG/SurveyValidation#QuasarsQSO22:MultivariateSelection

to reflect your new selection?

@geordie666
Copy link
Contributor Author

geordie666 commented Jan 16, 2019

@CAClaveau: After our conversation over email, I've made your requested corrections to the SV QSO selection code. Can you please check to see if this now looks correct?

Copy link
Contributor

@CAClaveau CAClaveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geordie666: OK, everything looks correct, thank you.

@geordie666 geordie666 merged commit 39535cc into master Jan 17, 2019
@geordie666 geordie666 deleted the ADMqsoSV branch January 17, 2019 21:00
qmxp55 pushed a commit to qmxp55/desitarget that referenced this pull request Feb 12, 2020
Update QSO selection for SV, minor improvements to random catalog generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants