Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some warnings from python 3.8 + numpy 1.18.5:
where
on scalars, thus necessitatingmore verbose
if np.isscalar(x) ... else ...
code.np.median
on empty slices (previously that would return a NaN, sostill using that if the slice was empty).
Tests pass at NERSC using both the current desi environment with python/3.6 + numpy/1.16.4 and a test python/3.8 + numpy/1.18.5 environment, but I'm not sure if the tests cover the Gaia NaN and QA empty slice cases so please take a look.