support mock QA with fitsio>1.0 (bytes vs. str) #634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #632 so that mock QA works with fitsio > 1.0 by adding extra bytes vs. str checks. It adds some trimmed down mock targets+truth test data and uses that to test mock QA. I have tested with with both fitsio/0.9.11 and fitsio/1.1.2 .
As a cleanup measure, this PR also wraps all
test/make_test*.py
code inif __name__ == "__main__":
blocks so that importing the code (e.g. by some documentation scraper) doesn't accidentally trigger trying to regenerate the test datasets.