Update Travis for the Python 3.8/Astropy 4.x combination #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pip for photutils)
sbailey
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Looks good, thanks. For the record, regarding some tests on py3.6 and others on py3.8, I view it as a feature rather than a problem when the Travis tests have somewhat different versions of numpy etc. than NERSC so we get additional coverage since people's laptops may also have significantly newer or older versions than what is current at NERSC. Good to update tests to fitsio/1.x and astropy/4.x though since we no longer support fitsio/0.x and astropy/2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the online Travis tests to better resemble the
desiconda 20.8release, which addresses #639.Basically, we switch the
.travis.ymlfile to installPython 3.8,Numpy 1.19.1andAstropy 4.0.1for tests. This also facilitates a few more updates, such as usinghealpy 1.14.0andpip 20.2.2.Although the key tests are updated for the
Python 3.8/Astropy 4.0.1combination, the "stable" test (which is an allowed failure) and the sphinx build still usePython 3.6. It didn't seem straightforward to update these tests to usePython 3.8(yet), and it isn't as critical that these tests align exactly with the environment at NERSC.This PR also brought along a useful script that can generate the QSO Random Forest probabilities for a target (or sweeps) file for post-facto analysis.