Bgs sv update #659
Merged
Bgs sv update #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2020 16:35
GALAXY imaging_mask was missing from BGS MAIN
Three main changes: 1) We've removed the FRACS* cuts. 2)the LOWQ superset does include rejections by the FRACS*. 3) The FIBMAG superset has been shrunk to the limit of 20.5 instead 21.0 in the r-band magnitude.
changes saved to changes.srt document
|
wiki has been updated https://desi.lbl.gov/trac/wiki/TargetSelectionWG/SurveyValidation |
geordie666
requested changes
Dec 4, 2020
There was a problem hiding this comment.
@qmxp55: I have a couple of minor comments. Once you've addressed those, let me know if this is final and I can merge it (once tests pass).
mising pull request reference number
geordie666
approved these changes
Dec 5, 2020
|
Thanks, @geordie666 I've just fixed this. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes for BGS SV selection:
(1) We've removed the FRACS* cuts. but the LOWQ superset does include rejections by the FRACS*.
(2) The FIBMAG superset has been shrunk to the limit of 20.5 instead 21.0 in the r-band magnitude.