Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize retuning of LRG cuts for DR9 and modify LRG SV bits #661

Merged
merged 9 commits into from Dec 9, 2020

Conversation

geordie666
Copy link
Contributor

This PR supersedes #660. It includes code to:

  • Retune the LRG cuts for DR9 and update the LRG SV target bits.
  • Switch to only using the default BRIGHT, GALAXY and CLUSTER masks in MASKBITS (i.e. ignoring ALLMASK and MEDIUM).
  • Increase the SV faint limits from z < 20.5 to z < 21.0 and from zfiber < 21.9 to zfiber < 22.0.

@geordie666
Copy link
Contributor Author

@rongpu: I incorporated your work from PR #660 into this branch. A bunch of function calls needed to be modified to account for your new inputs to the isLRG() function and I figured it would be most expedient to make those changes myself. I believe that unit tests should now pass on this branch. But, could you quickly check that I didn't actually change any of your intended cuts?

If you think this looks good, I'll merge it once unit tests pass.

@rongpu
Copy link
Contributor

rongpu commented Dec 9, 2020

@geordie666 I checked these changes and they look good. Thanks!

@geordie666 geordie666 merged commit 5b8b8d7 into master Dec 9, 2020
@geordie666 geordie666 deleted the rongpuwip branch December 9, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants