Finalize dedicated secondaries for SV1 to SV2 transition #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between SV1 and SV2 we intend to observe a number of dedicated tiles populated by secondary targets. This PR prepares the code for those observations by adding some new secondary target classes to the sv1 bitmasks.
This PR also deprecates handling Targets of Opportunity via the regular secondary targeting approach. Targets of Opportunity will instead be handled using a ledger through a separate mechanism.
I'll merge this in a few hours so I can make a new tag in preparation for running files that include the new dedicated secondary targets, which might be observed as early as next week.