Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New secondary bits for the COSMOS dedicated programs and for unusual point sources. #682

Merged
merged 2 commits into from Mar 13, 2021

Conversation

geordie666
Copy link
Contributor

This PR:

  • updates the SV1 secondary targeting bits with the latest (final) versions for the dedicated programs in COSMOS.
  • deprecates some earlier bits for those COSMOS programs which correspond to defunct selections.
  • adds the bits for the unusual point sources secondary program (PSF_OUT_BRIGHT, PSF_OUT_DARK).

There is no new code, other than updating bit-masks, so I'll merge as soon as tests pass to make a new tag for the new secondary targets.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.17% when pulling 9259012 on ADM-sec-cosmos into 2e62f51 on master.

@geordie666 geordie666 merged commit 57d4a44 into master Mar 13, 2021
@geordie666 geordie666 deleted the ADM-sec-cosmos branch March 13, 2021 16:30
@sbailey
Copy link
Contributor

sbailey commented Mar 15, 2021

@geordie666 can you confirm that the deprecated/replaced bits were never used for tiles that were observed?

@geordie666
Copy link
Contributor Author

I can't. Unfortunately, because of the way secondary targeting works, if people request a similar targeting set multiple times there is no way to determine an unambiguous SCND_ORDER for those target classes. So, a new bit has to be cut and the previous bit has to be removed. The deprecated bits should all be for DEDICATED programs, though. So, people who are interested in DEDICATED secondary programs just need to remember to use the mask that corresponds to the version of the code used to process their targets. This is unfortunate, but I hadn't envisioned that we'd be updating secondary targets in official versions of the code 2, 3 even 4 times before observing DEDICATED tiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants