Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clean-up for the 1% Survey #691

Merged
merged 11 commits into from Mar 25, 2021
Merged

Some clean-up for the 1% Survey #691

merged 11 commits into from Mar 25, 2021

Conversation

geordie666
Copy link
Contributor

@geordie666 geordie666 commented Mar 25, 2021

This PR implements some recent changes decided on Target Selection and Operations meetings, and cleans up some code related to MTL for the 1% Survey. It includes:

  • Don't allow BGS_FAINT targets in DARK observing conditions.
  • Trigger a warning when primary targets are encountered that might be too bright (total fluxes or Gaia magnitudes in any band brighter than 16th mag).
  • Have a single function for calculating UTC time stamps.
  • Functionality to read the state of a ledger strictly before a certain UTC (ISO) time-stamp.
  • Refactor and speed up routines to match arrays on TARGETID.

@geordie666
Copy link
Contributor Author

@araichoor and @ashleyjross: This PR includes your requested functionality to make UTC/ISO time stamps in a single function that can be shared by fiberassign scripts related to MTL. It also adds a keyword (isodate) to revert an MTL ledger to its state at a specific ISO time.

@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage increased (+0.04%) to 60.732% when pulling fe2db94 on ADM-gen-clean into e9d5ffe on master.

@geordie666 geordie666 merged commit 4e30e82 into master Mar 25, 2021
@geordie666 geordie666 deleted the ADM-gen-clean branch March 25, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants