Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ELG_LOP back to being its own target class for SV3 #701

Merged
merged 3 commits into from Mar 31, 2021

Conversation

geordie666
Copy link
Contributor

@djschlegel and @araichoor pointed out that it was probably a bad idea to change the meaning of the ELG bit, as I did in #700. So, this PR reverts back to the old meanings for the ELGs. To be clear, as of now (and forevermore for the purposes of sv3):

  • The bit ELG_LOP means a low-priority ELG.
  • The bit ELG_HIP means a high-priority ELG.
  • The bit ELG means either a low-priority ELG or a high-priority ELG (ELG is ELG_LOP | ELG_HIP).

To ensure the correct prioritization behavior, the MTL code (for sv3) now utilizes ELG_LOP and ELG_HIP and ignores ELG completely.

I'll run replacement targeting files soon and email desi-targets indicating the location of the new files.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 60.648% when pulling 69486b6 on ADM-revert-ELG into c36a128 on master.

@geordie666 geordie666 merged commit 8a7c1b0 into master Mar 31, 2021
@geordie666 geordie666 deleted the ADM-revert-ELG branch March 31, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants