New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly permit SCND bits that can update match MWS primaries #716
Conversation
Thanks @apcooper . Please update the variable names and comments to avoid "whitelist" (and implied "blacklist") terminology. allow / permit / include / override are possible alternatives. |
@apcooper: Just so you know, I took the updates you made in the bit-mask yaml file in this branch and ported them to the Main Survey bit-mask yaml file in my working branch. So, you won't need to also do that in this PR. In other words, I have retained your |
@geordie666 OK thanks for doing that. You say I won't need to do that -- I've done it already, so do I need to undo anything? @sbailey noted, will fix. |
Yeah, if you could remove any changes in |
@geordie666 I think this is working -- I've tested it a bit and have corresponding unit tests, but some of them assume things are set up as expected in the The result of this PR is that the previous behavior is recovered if and only if updatemws=True. @sbailey I've changed the terminology. |
The last commit seems harmless and allows the tests to pass in without corresponding changes to ps. "options" in the commit message should be "optional". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apcooper. This looks like carefully written code, as always. I checked a few basic use cases and it seems to work fine.
I have a couple of comments regarding backwards compatibility and the tangled web of PRs we've been creating. But, feel free to merge once those comments are addressed.
Looks good! Feel free to merge once tests pass. |
Explicitly permit secondary bits that can change the state of matched MWS primary targets.
Previous behaviour was to allow such updates to be driven by any target with SCND_ANY. Now checks for
mwsupdate=True
flag in target bit definition.